Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
This is a little follow-up to PR #1375 and issue #489
I realized and fixed 2 problems with the API as defined previously:
par_out
of AVBSFContext stands for output parameters and it contains the codec parameters as modified by the bitfilter. This needs to be exposed so that the user can get the modified codec.Here's a minimal example that shows example expected usage and why it's useful to separate the input and output arguments:
av_bsf_flush
is useful during discontinuous demuxing, e.g. after seeking. It allows reset of the internal bitfilter state. Otherwise you'd have to destroy and recreate the filter every time after seeking/draining the internal filter buffer. This is now exposed asBitStreamFilterContext.flush()
. I also added a test case for this function.