Getter tests for packet properties #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeSchiff
force-pushed
the
test_props
branch
2 times, most recently
from
c722050
to
5c2a6e4
Compare
…_discard, is_disposable
|
Is homebrew breaking our tests? |
|
I think FATE is down. The tests pass on my local machine so it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to help finish #1138.
I searched through the FATE suite and I was able to find files with
corrupt,discard, anddisposablepacket flags. I was unable to find a file with atrustedflag.I then used ffprobe to determine the packet indices for
keyframe,corrupt, anddiscardflags in their respective files, but I could not detect thedisposableflag.I'm guessing ffprobe doesn't provide that flag by default. Does anyone know how to get more details about flags?
These are the commands I tried:
ffprobe -show_entries packet=flags "$file"ffprobe -show_packets "$file"