Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stubs in av.video #1317

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Conversation

laggykiller
Copy link
Contributor

No description provided.

av/video/stream.pyi Outdated Show resolved Hide resolved
av/video/frame.pyi Outdated Show resolved Hide resolved
av/video/frame.pyi Outdated Show resolved Hide resolved
@laggykiller
Copy link
Contributor Author

I wanted to also add codec_context typing in av.audio.stream.AudioStream, but that caused conflict...

@WyattBlue
Copy link
Member

You should just overwrite your previous commit then force push. It's okay when it's on your branch.

@laggykiller
Copy link
Contributor Author

laggykiller commented Mar 5, 2024

Should I open another PR for changing codec_context in av.audio.stream.AudioStream? Or should I just leave that to you?

Another option is I revert #1316 now and sneak in this change

@WyattBlue
Copy link
Member

Once a PR is merged in main. You can't revert it.

Just make a new PR.

@laggykiller
Copy link
Contributor Author

Sure! Opened #1321

@WyattBlue WyattBlue merged commit 1bddc7e into PyAV-Org:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants