Language: Array to string warning on string-offset assign (#22925) - #22976
Merged
Conversation
Match Zend zend_assign_to_string_offset: coerce array RHS with Array to string conversion before the first-byte warning. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array to string conversionwarning beforeOnly the first byte will be assigned…, then writes'A'(first byte of"Array").Variable::byteFromAssignValue— TYPE_ARRAY path +emitArrayToStringWarningfallback Context from the offset slot.StringOffsetRuntime::assignBytehandlesTYPE_HASHTABLEwith the same two warnings.Closes #22925
php-src reference
Zend/zend_execute.c—zend_assign_to_string_offsetZend/zend_operators.c— array → string conversionPHP implementation
lib/VM/Variable.php(php-in-PHP; no new C)lib/JIT/Builtin/StringOffsetRuntime.php+StringOffsetJitHelper::ARRAY_TO_STRING_WARNINGTrust probe (before claim)
bootstrap-inventory --checkOK 6518/6518(post-fix)north-star5-fastvm-driver-probeuser_release_readyTest plan
vendor/bin/phpunit --filter string_offset_array_assign_warning→ OKstring_offset_*VM compliance → OK (17)php script/bootstrap-inventory.php --check→OK 6518/6518C runtime: 0 lines added.
Made with Cursor