Stdlib: NumberFormatter::parse U_PARSE_ERROR without global pollution (#22855)#22975
Merged
Conversation
… pollution (#22855) Match php-src: object error code 9 and message without numfmt_parse: prefix; leave intl_get_error_code() at 0 after a failed parse. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumberFormatter::parse/parseCurrencynow set object error 9 (U_PARSE_ERROR) with Zend messageNumber parsing failed: U_PARSE_ERROR(nonumfmt_parse:prefix).intl_get_error_code()stays 0 (object-only failure path).Closes #22855
php-src reference
ext/intl/formatter/formatter_main.c— parse status / error reportingPHP implementation
ext/intl/VmNumberFormatter.php—failParse()Test plan
php bin/vm.php test/repro/issue_22855_numfmt_parse_error.php→ false / 9 / Number parsing failed… / 0vendor/bin/phpunit --filter numberformatter_parse_error(+ related parse) → OK (8)Batch: #22870 + #22877 merged; this is #3.
Made with Cursor