Stdlib: IntlDateFormatter @calendar= TRADITIONAL via ICU udat (#22877)#22972
Merged
Conversation
Honor locale calendar keywords for hebrew/islamic/japanese/buddhist with a thin libicui18n udat_open/format FFI path (php-src dateformat_create.cpp). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntlDateFormatterwithTRADITIONAL+ locale@calendar=hebrew|islamic|japanese|buddhistnow formats via ICUudat_open/udat_format(thin FFI inIcuDateFormat), matching Zend date strings.@…extensions in style-table locale fallback; Gregorian path unchanged when ICU is unused.$loc).Closes #22877
php-src reference
ext/intl/dateformat/dateformat_create.cpp—udat_open(timeStyle, dateStyle, locale, …)+ calendar from locale when TRADITIONALPHP implementation
ext/intl/IcuDateFormat.php— udat_* FFIext/intl/VmIntlDateFormatter.php—usesLocaleCalendarKeyword/formatResolvedTest plan
php bin/vm.php test/repro/issue_22877_datefmt_calendar_locale.php→ Tevet / AH / Shōwa / BEvendor/bin/phpunit --filter intldateformatter_calendar_locale→ OKBatch: after #22870; next #22855.
Made with Cursor