ENABLE-140 Component Cookie Banner #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CSS styling complete.
ocjadan
added
the
component development
zoltan-dulac
requested changes
Jul 24, 2024
| <button id="show-non-modal-button">Show Non-Modal Banner</button> | ||
|
|
||
| <div id="cookie-banner-container"> | ||
| <dialog id="cookie-banner" class="cookie-banner"> |
There was a problem hiding this comment.
Because this is a non-modal, I think it better to not use the dialog tag to encapsulate the cookie banner in the non-modal case. I think
would be better (witharia-labeledby pointing to the title of the banner.
You should use for the modal case, but make sure you follow all the instructions in dialog.php.
There was a problem hiding this comment.
Hi @zoltan-dulac , could you share why the <aside> tag would be appropriate for a cookie banner. If we trade <dialog> in favor of <aside> then we also lose the following benefits:
- The
.show()method which positions the contents above everything else on the page, but "still allowing interaction with content outside of the dialog". MDN link - The combination of using a <form> tag with its method attribute set to "dialog", which results in automatic dismissal of the dialog when a button is pressed.
We'd have to program these functionalities ourselves when using the <aside> tag, and also convince users of Enable to do the same.
There was a problem hiding this comment.
Zoltan: "Will check with Allison regarding the .show() method."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.