Fix/validate on reuse misleading #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix, if you set validateOnReuse to false, this only prevented the error from being thrown, it did not actually prevent validation from happening. This means if you were to make a GET request without including the token in the request and you were hoping to have the existing CSRF token included in the response, it wasn't really possible, a new one would be generated every time. It should not be necessary to included the CSRF token in GET requests. Now when validateOnReuse is false, the existing CSRF token will be reused from the CSRF token cookie, without prior validation. This is a semi breaking change, but it is a correction of expected behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateOnReusebehaviour was incorrect, it was always "intentionally incorrect", but it had not previously been made apparent on why this may have been problematic.This corrects the behaviour.
The problem:
Even when
validateOnReuseis set to false (its default value), it doesn't prevent validation, it only prevents an error from being thrown. This means anyGETrequests which expect the existing token to be used but do not include the CSRF token in the request such thatgetTokenFromRequestwill return it, this causes an invalidation and a new token to be generated.Up until now, this behaviour had been intentional, but this is not the desired behaviour.
This PR fixes that.