Sync fork #10
Closed
Sync fork #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes facebook#233. This PR adds the `setAdvertiserTrackingEnabled(advertiser_tracking_enabled: boolean)` method to the `ServerEvent` class. I have not added any new tests, following the style of code/test in other methods of the `ServerEvent` class. If you would like tests to be added, please let me know! There is a pre-existing failing test in unchanged code: ``` FAIL __tests__/signal.test.js ● Signal Data › Event › Event creation ReferenceError: data_processing_options_state is not defined at ServerEvent.data_processing_options_state (dist/objects/serverside/server-event.js:381:41) at Event.setDataProcessingOptionsState (dist/objects/signal/event.js:348:9) at Object.setDataProcessingOptionsState (__tests__/signal.test.js:394:18) ``` I attempted to run the semistandard linter, but it ended up with changes to every single src file -- not sure if there is a config error in the repo somewhere? Thanks! 😄 Pull Request resolved: facebook#249 Reviewed By: mengxuanzhangz Differential Revision: D46075345 Pulled By: stcheng fbshipit-source-id: c569682c1583d8cb8610d01b955487a6bd332374
Summary: Fix the function name and argument of set advanced_measurement_table Reviewed By: mengxuanzhangz Differential Revision: D46075867 fbshipit-source-id: 0b18bca484a466c0a1e9cc135743df5b05fbd342
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D46256506 fbshipit-source-id: dc96ff635fa46d8a193460422aadc96947e30a13
Summary: [BizSDK][NodeJS] Fix Quote Bug Missing Escape Backslash The auto-gen script needs to be fixed to cope with such scenario! :) Reviewed By: mengxuanzhangz Differential Revision: D46808758 fbshipit-source-id: fafe810deb672dc389f4b400b3389f0e9c6d2451
Summary: [BizSDK] Remove Single Quote Marks Completely to Avoid Bugs The introduction of single quote marks breaks languages, e.g. Python, Ruby, and PHP. Remove this entirely to mitigate this issue immediately and unblock the release of v18. Reviewed By: mengxuanzhangz Differential Revision: D46813106 fbshipit-source-id: d39d417b61d59c38a35d8674c7a7679defc1e31d
Summary: [BizSDK] Bump Version to 17.0.1 to Address Single Quote Issue Bump the version to release a new minor version to address the issue Reviewed By: mengxuanzhangz Differential Revision: D46815647 fbshipit-source-id: 7c2be171a10452aa7d3870592f0861a5399111e0
…ountry (facebook#214) Summary: facebook#200 Pull Request resolved: facebook#214 Reviewed By: mengxuanzhangz Differential Revision: D47440770 Pulled By: stcheng fbshipit-source-id: b0b1069353bb4a42e32ce9fc2ae44ba70cf90a48
facebook#254) Summary: Currently `advertiser_tracking_enabled()` is returning `_data_processing_options_country`, it should be returning `_advertiser_tracking_enabled` instead. Pull Request resolved: facebook#254 Reviewed By: mengxuanzhangz Differential Revision: D47440402 Pulled By: stcheng fbshipit-source-id: f9d646a5087eb4f221ea998a339412194bfb8319
Summary: [BizSDK][NodeJS] Allow False for Parameter advertiser_tracking_enabled Reviewed By: mengxuanzhangz Differential Revision: D47442696 fbshipit-source-id: 16a551ec7bb4d8fe3dc5312d91b837fc0a9431b6
Summary: [BizSDK][API-Spec] Add DSA Support on AdAccount Add default_dsa_beneficiary and default_dsa_payor two fields in adaccount.json file. Reviewed By: scutexasece Differential Revision: D48134776 fbshipit-source-id: b672146998f4eac5d20ac2e04624c4b41dceafd1
Summary: [BizSDK][NodeJS] Remove dependency request from package.json `request` package has long been deprecated and shall be replaced. Remove `request` and `request-promise` dependencies. Use `axios` as a replacement. Update `api.js` and `http.js` during migration. Set `response` to `response.data` due to the return format of Axios response format change. Known issue axios/axios#5332. Reviewed By: mengxuanzhangz Differential Revision: D48271770 fbshipit-source-id: f22e5e336cbf9f69cdd597fea62ca08822ce72fd
Summary: [BizSDK][NodeJS] Exclude Malformed File in Flow Config This file is deliberately malformed and shall not be included in the flow check. Reviewed By: mengxuanzhangz Differential Revision: D48331540 fbshipit-source-id: 4f6806b223dfb555b6ea4965d657975cfc34ddc9
Summary: [BizSDK][NodeJS] Fix preview Keyword Update NodeJS after removing views from the keyword list Reviewed By: mengxuanzhangz Differential Revision: D48488629 fbshipit-source-id: e2538b38c5fd0f8e5fd4e5a983af89c5c2b9b6fb
Summary: Bumps [eslint](https://github.com/eslint/eslint) from 4.19.1 to 7.32.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p> <blockquote> <h2>v7.32.0</h2> <ul> <li><a href="https://github.com/eslint/eslint/commit/3c78a7bff6044fd196ae3b737983e6744c6eb7c8"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14841">#14841</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/faecf56cdb4146b28bfa4f1980adb41b4d3614b1"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14766">#14766</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/d7dc07a15e256cee9232183165e2f6102f2c0873"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14837">#14837</a>) (Soufiane Boutahlil)</li> <li><a href="https://github.com/eslint/eslint/commit/1bfbefdaaf19ef32df42b89a3f5d32cff1e5b831"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14730">#14730</a>) (Antonios Katopodis)</li> <li><a href="https://github.com/eslint/eslint/commit/ed007c82ee9d2170c87500d98303554b5f90b915"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14842">#14842</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/d53d9064b9dd0dd6a8ea39e07b16310c8364db69"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14830">#14830</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/d28f2ffb986e49d6da5c1d91215580591f4cfd35"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14805">#14805</a>) (Brett Zamir)</li> <li><a href="https://github.com/eslint/eslint/commit/8be8a36010145dfcd31cbdd4f781a91989e3b1bd"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14823">#14823</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/f9c164f7b74ca73384c8c80eed5bdbe359b44f6c"><code>f9c164f</code></a> Docs: New syntax issue template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14826">#14826</a>) (Nicholas C. Zakas)</li> <li><a href="https://github.com/eslint/eslint/commit/eba0c4595c126a91f700d5f2e8723ec3f820a830"><code>eba0c45</code></a> Chore: assertions on reporting loc in <code>unicode-bom</code> (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14809">#14809</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/ed945bd662714b1917e9de71d5b322a28be9161b"><code>ed945bd</code></a> Docs: fix multiple broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14833">#14833</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/60df44c79b0f74406119c0c040a360ca84e721fc"><code>60df44c</code></a> Chore: use <code>actions/setup-node@v2</code> (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14816">#14816</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/6641d88e17d952a8e51df5e0d3882a842d4c3f35"><code>6641d88</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> </ul> <h2>v7.31.0</h2> <ul> <li><a href="https://github.com/eslint/eslint/commit/efdbb1227019427ec2d968a8d6e9151dd8a77c35"><code>efdbb12</code></a> Upgrade: <code>@eslint/eslintrc</code> to v0.4.3 (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14808">#14808</a>) (Brandon Mills)</li> <li><a href="https://github.com/eslint/eslint/commit/a96b05f6c5649cfee112d605c91d95aa191e2f78"><code>a96b05f</code></a> Update: add end location to report in <code>consistent-return</code> (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14798">#14798</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/e0e8e308929c9c66612505f2da89043f8592eea7"><code>e0e8e30</code></a> Docs: update BUG_REPORT template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14787">#14787</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/39115c8b71d2629161359f6456f47fdbd552fddd"><code>39115c8</code></a> Docs: provide more context to no-eq-null (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14801">#14801</a>) (gfyoung)</li> <li><a href="https://github.com/eslint/eslint/commit/9a3c73c130d437a65f4edba0dcb63390e68cac41"><code>9a3c73c</code></a> Docs: fix a broken link (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14790">#14790</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/ddffa8ad58b4b124b08061e9045fdb5370cbdbe3"><code>ddffa8a</code></a> Update: Indicating the operator in question (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14764">#14764</a>) (Paul Smith)</li> <li><a href="https://github.com/eslint/eslint/commit/bba714c2ed813821ed288fbc07722cdde6e534fe"><code>bba714c</code></a> Update: Clarifying what changes need to be made in no-mixed-operators (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14765">#14765</a>) (Paul Smith)</li> <li><a href="https://github.com/eslint/eslint/commit/b0d22e3eff18ea7f08189134c07cddceaec69a09"><code>b0d22e3</code></a> Docs: Mention benefit of providing <code>meta.docs.url</code> (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14774">#14774</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/000cc796fd487e7b9ba8bcc5857dd691044479cc"><code>000cc79</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> <li><a href="https://github.com/eslint/eslint/commit/a6a7438502abc6a1e29ec35cfbe2058ffc0803b1"><code>a6a7438</code></a> Chore: pin [email protected] (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14771">#14771</a>) (Milos Djermanovic)</li> </ul> <h2>v7.30.0</h2> <ul> <li><a href="https://github.com/eslint/eslint/commit/5f746420700d457b92dd86659de588d272937b79"><code>5f74642</code></a> Chore: don't check Program.start in SourceCode#getComments (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14744">#14744</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14748">#14748</a>) (Milos Djermanovic)</li> <li><a href="https://github.com/eslint/eslint/commit/19a871a35ae9997ce352624b1081c96c54b73a9f"><code>19a871a</code></a> Docs: Suggest linting plugins for ESLint plugin developers (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14754">#14754</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/aa87329d919f569404ca573b439934552006572f"><code>aa87329</code></a> Docs: fix broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14756">#14756</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/278813a6e759f6b5512ac64c7530c9c51732e692"><code>278813a</code></a> Docs: fix and add more examples for new-cap rule (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12874">#12874</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14725">#14725</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/ed1da5d96af2587b7211854e45cf8657ef808710"><code>ed1da5d</code></a> Update: ecmaVersion allows "latest" (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14720">#14720</a>) (薛定谔的猫)</li> <li><a href="https://github.com/eslint/eslint/commit/104c0b592f203d315a108d311c58375357e40b24"><code>104c0b5</code></a> Update: improve use-isnan rule to detect <code>Number.NaN</code> (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14715">#14715</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14718">#14718</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/b08170b92beb22db6ec612ebdfff930f9e0582ab"><code>b08170b</code></a> Update: Implement FlatConfigArray (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13481">#13481</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14321">#14321</a>) (Nicholas C. Zakas)</li> <li><a href="https://github.com/eslint/eslint/commit/f113cdd872257d72bbd66d95e4eaf13623323b24"><code>f113cdd</code></a> Chore: upgrade eslint-plugin-eslint-plugin (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14738">#14738</a>) (薛定谔的猫)</li> <li><a href="https://github.com/eslint/eslint/commit/1b8997ab63781f4ebf87e3269400b2ef4c7d2973"><code>1b8997a</code></a> Docs: Fix getRulesMetaForResults link syntax (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14723">#14723</a>) (Brandon Mills)</li> <li><a href="https://github.com/eslint/eslint/commit/aada733d2aee830aa32cccb9828cd72db4ccd6bd"><code>aada733</code></a> Docs: fix two broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14726">#14726</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/8972529f82d13bd04059ee8852b4ebb9b5350962"><code>8972529</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> </ul> <h2>v7.29.0</h2> <ul> <li><a href="https://github.com/eslint/eslint/commit/bfbfe5c1fd4c39a06d5e159dbe48479ca4305fc0"><code>bfbfe5c</code></a> New: Add only to RuleTester (refs <a href="https://github-redirect.dependabot.com/eslint/rfcs/issues/73">eslint/rfcs#73</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14677">#14677</a>) (Brandon Mills)</li> <li><a href="https://github.com/eslint/eslint/commit/c2cd7b4a18057ca6067bdfc16de771dc5d90c0ea"><code>c2cd7b4</code></a> New: Add ESLint#getRulesMetaForResults() (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13654">#13654</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14716">#14716</a>) (Nicholas C. Zakas)</li> <li><a href="https://github.com/eslint/eslint/commit/eea7e0d09d6ef43d6663cbe424e7974764a5f7fe"><code>eea7e0d</code></a> Chore: remove duplicate code (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14719">#14719</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/6a1c7a0dac050ea5876972c50563a7eb867b38d3"><code>6a1c7a0</code></a> Fix: allow fallthrough comment inside block (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14701">#14701</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14702">#14702</a>) (Kevin Gibbons)</li> <li><a href="https://github.com/eslint/eslint/commit/a47e5e30b0da364593b6881f6826c595da8696f5"><code>a47e5e3</code></a> Docs: Add Mega-Linter to the list of integrations (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14707">#14707</a>) (Nicolas Vuillamy)</li> <li><a href="https://github.com/eslint/eslint/commit/353ddf965078030794419b089994373e27ffc86e"><code>353ddf9</code></a> Chore: enable reportUnusedDisableDirectives in eslint-config-eslint (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14699">#14699</a>) (薛定谔的猫)</li> <li><a href="https://github.com/eslint/eslint/commit/757c49584a5852c468c1b4a0b74ad3aa39d954e5"><code>757c495</code></a> Chore: add some rules to eslint-config-eslint (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14692">#14692</a>) (薛定谔的猫)</li> <li><a href="https://github.com/eslint/eslint/commit/c93a222563177a9b5bc7a59aa106bc0a6d31e063"><code>c93a222</code></a> Docs: fix a broken link (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14697">#14697</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/655c1187fc845bac61ae8d06c556f1a59ee2071b"><code>655c118</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/blob/master/CHANGELOG.md">eslint's changelog</a>.</em></p> <blockquote> <p>v7.32.0 - July 30, 2021</p> <ul> <li><a href="https://github.com/eslint/eslint/commit/3c78a7bff6044fd196ae3b737983e6744c6eb7c8"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14841">#14841</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/faecf56cdb4146b28bfa4f1980adb41b4d3614b1"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14766">#14766</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/d7dc07a15e256cee9232183165e2f6102f2c0873"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14837">#14837</a>) (Soufiane Boutahlil)</li> <li><a href="https://github.com/eslint/eslint/commit/1bfbefdaaf19ef32df42b89a3f5d32cff1e5b831"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14730">#14730</a>) (Antonios Katopodis)</li> <li><a href="https://github.com/eslint/eslint/commit/ed007c82ee9d2170c87500d98303554b5f90b915"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14842">#14842</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/d53d9064b9dd0dd6a8ea39e07b16310c8364db69"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14830">#14830</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/d28f2ffb986e49d6da5c1d91215580591f4cfd35"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14805">#14805</a>) (Brett Zamir)</li> <li><a href="https://github.com/eslint/eslint/commit/8be8a36010145dfcd31cbdd4f781a91989e3b1bd"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14823">#14823</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/f9c164f7b74ca73384c8c80eed5bdbe359b44f6c"><code>f9c164f</code></a> Docs: New syntax issue template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14826">#14826</a>) (Nicholas C. Zakas)</li> <li><a href="https://github.com/eslint/eslint/commit/eba0c4595c126a91f700d5f2e8723ec3f820a830"><code>eba0c45</code></a> Chore: assertions on reporting loc in <code>unicode-bom</code> (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14809">#14809</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/ed945bd662714b1917e9de71d5b322a28be9161b"><code>ed945bd</code></a> Docs: fix multiple broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14833">#14833</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/60df44c79b0f74406119c0c040a360ca84e721fc"><code>60df44c</code></a> Chore: use <code>actions/setup-node@v2</code> (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14816">#14816</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/6641d88e17d952a8e51df5e0d3882a842d4c3f35"><code>6641d88</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> </ul> <p>v7.31.0 - July 17, 2021</p> <ul> <li><a href="https://github.com/eslint/eslint/commit/efdbb1227019427ec2d968a8d6e9151dd8a77c35"><code>efdbb12</code></a> Upgrade: <code>@eslint/eslintrc</code> to v0.4.3 (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14808">#14808</a>) (Brandon Mills)</li> <li><a href="https://github.com/eslint/eslint/commit/a96b05f6c5649cfee112d605c91d95aa191e2f78"><code>a96b05f</code></a> Update: add end location to report in <code>consistent-return</code> (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14798">#14798</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/e0e8e308929c9c66612505f2da89043f8592eea7"><code>e0e8e30</code></a> Docs: update BUG_REPORT template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14787">#14787</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/39115c8b71d2629161359f6456f47fdbd552fddd"><code>39115c8</code></a> Docs: provide more context to no-eq-null (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14801">#14801</a>) (gfyoung)</li> <li><a href="https://github.com/eslint/eslint/commit/9a3c73c130d437a65f4edba0dcb63390e68cac41"><code>9a3c73c</code></a> Docs: fix a broken link (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14790">#14790</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/ddffa8ad58b4b124b08061e9045fdb5370cbdbe3"><code>ddffa8a</code></a> Update: Indicating the operator in question (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14764">#14764</a>) (Paul Smith)</li> <li><a href="https://github.com/eslint/eslint/commit/bba714c2ed813821ed288fbc07722cdde6e534fe"><code>bba714c</code></a> Update: Clarifying what changes need to be made in no-mixed-operators (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14765">#14765</a>) (Paul Smith)</li> <li><a href="https://github.com/eslint/eslint/commit/b0d22e3eff18ea7f08189134c07cddceaec69a09"><code>b0d22e3</code></a> Docs: Mention benefit of providing <code>meta.docs.url</code> (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14774">#14774</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/000cc796fd487e7b9ba8bcc5857dd691044479cc"><code>000cc79</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> <li><a href="https://github.com/eslint/eslint/commit/a6a7438502abc6a1e29ec35cfbe2058ffc0803b1"><code>a6a7438</code></a> Chore: pin [email protected] (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14771">#14771</a>) (Milos Djermanovic)</li> </ul> <p>v7.30.0 - July 2, 2021</p> <ul> <li><a href="https://github.com/eslint/eslint/commit/5f746420700d457b92dd86659de588d272937b79"><code>5f74642</code></a> Chore: don't check Program.start in SourceCode#getComments (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14744">#14744</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14748">#14748</a>) (Milos Djermanovic)</li> <li><a href="https://github.com/eslint/eslint/commit/19a871a35ae9997ce352624b1081c96c54b73a9f"><code>19a871a</code></a> Docs: Suggest linting plugins for ESLint plugin developers (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14754">#14754</a>) (Bryan Mishkin)</li> <li><a href="https://github.com/eslint/eslint/commit/aa87329d919f569404ca573b439934552006572f"><code>aa87329</code></a> Docs: fix broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14756">#14756</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/278813a6e759f6b5512ac64c7530c9c51732e692"><code>278813a</code></a> Docs: fix and add more examples for new-cap rule (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12874">#12874</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14725">#14725</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/ed1da5d96af2587b7211854e45cf8657ef808710"><code>ed1da5d</code></a> Update: ecmaVersion allows "latest" (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14720">#14720</a>) (薛定谔的猫)</li> <li><a href="https://github.com/eslint/eslint/commit/104c0b592f203d315a108d311c58375357e40b24"><code>104c0b5</code></a> Update: improve use-isnan rule to detect <code>Number.NaN</code> (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14715">#14715</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14718">#14718</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/b08170b92beb22db6ec612ebdfff930f9e0582ab"><code>b08170b</code></a> Update: Implement FlatConfigArray (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13481">#13481</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14321">#14321</a>) (Nicholas C. Zakas)</li> <li><a href="https://github.com/eslint/eslint/commit/f113cdd872257d72bbd66d95e4eaf13623323b24"><code>f113cdd</code></a> Chore: upgrade eslint-plugin-eslint-plugin (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14738">#14738</a>) (薛定谔的猫)</li> <li><a href="https://github.com/eslint/eslint/commit/1b8997ab63781f4ebf87e3269400b2ef4c7d2973"><code>1b8997a</code></a> Docs: Fix getRulesMetaForResults link syntax (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14723">#14723</a>) (Brandon Mills)</li> <li><a href="https://github.com/eslint/eslint/commit/aada733d2aee830aa32cccb9828cd72db4ccd6bd"><code>aada733</code></a> Docs: fix two broken links (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14726">#14726</a>) (Sam Chen)</li> <li><a href="https://github.com/eslint/eslint/commit/8972529f82d13bd04059ee8852b4ebb9b5350962"><code>8972529</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> </ul> <p>v7.29.0 - June 18, 2021</p> <ul> <li><a href="https://github.com/eslint/eslint/commit/bfbfe5c1fd4c39a06d5e159dbe48479ca4305fc0"><code>bfbfe5c</code></a> New: Add only to RuleTester (refs <a href="https://github-redirect.dependabot.com/eslint/rfcs/issues/73">eslint/rfcs#73</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14677">#14677</a>) (Brandon Mills)</li> <li><a href="https://github.com/eslint/eslint/commit/c2cd7b4a18057ca6067bdfc16de771dc5d90c0ea"><code>c2cd7b4</code></a> New: Add ESLint#getRulesMetaForResults() (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13654">#13654</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14716">#14716</a>) (Nicholas C. Zakas)</li> <li><a href="https://github.com/eslint/eslint/commit/eea7e0d09d6ef43d6663cbe424e7974764a5f7fe"><code>eea7e0d</code></a> Chore: remove duplicate code (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14719">#14719</a>) (Nitin Kumar)</li> <li><a href="https://github.com/eslint/eslint/commit/6a1c7a0dac050ea5876972c50563a7eb867b38d3"><code>6a1c7a0</code></a> Fix: allow fallthrough comment inside block (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14701">#14701</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14702">#14702</a>) (Kevin Gibbons)</li> <li><a href="https://github.com/eslint/eslint/commit/a47e5e30b0da364593b6881f6826c595da8696f5"><code>a47e5e3</code></a> Docs: Add Mega-Linter to the list of integrations (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14707">#14707</a>) (Nicolas Vuillamy)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eslint/eslint/commit/83cc8a6823d7729297b6814a644cca770cb99dbb"><code>83cc8a6</code></a> 7.32.0</li> <li><a href="https://github.com/eslint/eslint/commit/f10218d5547bdc10f50f133c697e0d1d9dba7956"><code>f10218d</code></a> Build: changelog update for 7.32.0</li> <li><a href="https://github.com/eslint/eslint/commit/3c78a7bff6044fd196ae3b737983e6744c6eb7c8"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14841">#14841</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/faecf56cdb4146b28bfa4f1980adb41b4d3614b1"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14766">#14766</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/d7dc07a15e256cee9232183165e2f6102f2c0873"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14837">#14837</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/1bfbefdaaf19ef32df42b89a3f5d32cff1e5b831"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14730">#14730</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/ed007c82ee9d2170c87500d98303554b5f90b915"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14842">#14842</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/d53d9064b9dd0dd6a8ea39e07b16310c8364db69"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14830">#14830</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/d28f2ffb986e49d6da5c1d91215580591f4cfd35"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14805">#14805</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/8be8a36010145dfcd31cbdd4f781a91989e3b1bd"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/14823">#14823</a>)</li> <li>Additional commits viewable in <a href="https://github.com/eslint/eslint/compare/v4.19.1...v7.32.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~eslintbot">eslintbot</a>, a new releaser for eslint since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Pull Request resolved: facebook#202 Reviewed By: mengxuanzhangz Differential Revision: D48205210 Pulled By: stcheng fbshipit-source-id: 58c35b8f036fd19d392599597d82e9d5e62847e7
Summary: [BizSDK][NodeJS] Remove gulp-flowtype Dependency This dependency is deprecated and no longer used. In the future we would like to evaluate if gulp itself is still needed in our project. Differential Revision: D48919251 fbshipit-source-id: ed8edc572c47c283710519db7fa5c173f9cc6673
Summary: [BizSDK][NodeJS] Update LICENSE and Header Reviewed By: mengxuanzhangz Differential Revision: D49198556 fbshipit-source-id: 60e37faca6057b8860b933532ef23376d2fb7bf5
Summary: This PR adds response headers to the returned ```Cursor``` object. Pull Request resolved: facebook#220 Reviewed By: mengxuanzhangz Differential Revision: D49285076 Pulled By: stcheng fbshipit-source-id: effe5f365eec11fc198a9384cc3f2b81407c1bac
Summary: Nothing breaking, but it might influence clarity and search functions. Pull Request resolved: facebook#175 Reviewed By: mengxuanzhangz Differential Revision: D49285291 Pulled By: stcheng fbshipit-source-id: 8fec298ae0a355322208914caeb8639590562e48
Summary: Because of this, when EventRequest normalizes the serverEvent, the normalize() function don't ever go inside the if(this.event_id) statement because this.event_id is not referring to the getter of the private property "eventID", but the wrong public property that is created inside the constructor. Pull Request resolved: facebook#216 Reviewed By: mengxuanzhangz Differential Revision: D49285160 Pulled By: stcheng fbshipit-source-id: 8c64a5f8d6d3839c237bf5c3f2be4693fe3689f5
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D49294351 fbshipit-source-id: 5e3e691e29446fe3451fc33f207edcce66626de4
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D49642941 fbshipit-source-id: 12d959c2e51d45106b5a8d7798fe21c65c5f0d91
Summary: [BizSDK][NodeJS] Address Error Parsing Issue for Axios Refer to https://github.com/axios/axios/blob/main/README.md#handling-errors to update the error handling logics in exceptions.js file. Address the issue facebook#262 Reviewed By: mengxuanzhangz Differential Revision: D50244205 fbshipit-source-id: 165ae2c2e088666912aadae45324eeafb1b8c93b
Summary: ignore-conflict-markers Reviewed By: mengxuanzhangz Differential Revision: D50280545 fbshipit-source-id: c964c2058a042e69818609f89579789a4f6d0dc7
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D50948130 fbshipit-source-id: 054f5b6988e1d8b61a7c499b4e1ad8c4605dad98
Summary: Fix fbc and fbp params comments Pull Request resolved: facebook#264 Reviewed By: mengxuanzhangz Differential Revision: D50807047 Pulled By: stcheng fbshipit-source-id: 7461765eb680acd51a79409e85f49e2cb9cd83ab
Summary: [BizSDK][nodejs] Fix Typo facebook#242 Differential Revision: D51078320 fbshipit-source-id: e3081aa0829403bebeb9d08de14136191d370b19
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D51766733 fbshipit-source-id: 1a28e8d74778c02df5a1eb3c88728bbfb05b2e7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.