Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -fPIC #829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add -fPIC #829

wants to merge 1 commit into from

Conversation

phcoder
Copy link
Contributor

@phcoder phcoder commented May 29, 2019

It's required to compile on aarch64 and doesn't hurt on
other platforms

@phcoder
Add -fPIC
14c765a 
It's requured to compile on aarch64 and doesn't hurt on
other platforms
pwpiwi
pwpiwi reviewed May 30, 2019
View reviewed changes
Copy link
Contributor

@pwpiwi pwpiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work and I couldn't see any performance issues.

With -fPIC as a standard flag, the addition of -fPIC in lines 86 and 96 is no longer required. Would you please remove these?

@pwpiwi
Copy link
Contributor

pwpiwi commented Jun 6, 2019

@phcoder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwpiwi pwpiwi pwpiwi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phcoder @pwpiwi