Open
Conversation
The document is served without an encoding header.
This factors in common parts of address parsing. There is a tweak to which errors are returned when the buffer is both too small for its declared length and for the minimum length of address data: in this case, we now return an UnexpectedEof indicating the first error, previously the second error was signaled. Tests were updated with larger vectors so they could still exercise InsufficientLengthSpecified error cases.
The ones supported are the ones documented in proxy-protocol.txt as of 2020/03/05.
Proximyst
approved these changes
Oct 1, 2021
Owner
Proximyst
left a comment
Proximyst
left a comment
There was a problem hiding this comment.
This looks very good! Though it is very late, so I'll have to bookmark to re-read tomorrow.
|
Hi! I'm wondering whether there have been any updates here yet? I'm using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for TLV extensions, as documented in proxy-protocol.txt
Comes with tests.
This will be a version bump, because the Version2 struct now has extra fields.
(FWIW, I think switching the parse side from an "impl Buf" to either Bytes or &[u8] slices (since we probably don't need to support discontinuous data) would make the implementation better by allowing to pass subslices instead of having to add len arguments. But I didn't add that API change.)
Closes #5.