-
-
Notifications
You must be signed in to change notification settings - Fork 693
.pr_agent_accepted_suggestions
root edited this page Dec 22, 2024
·
1 revision
PR 2363 (2024-12-02) |
[Possible issue] Remove extremely low CPU clock options that could cause system instability
✅ Remove extremely low CPU clock options that could cause system instability
Set a reasonable minimum CPU clock value (e.g., 25% or 50%) to prevent system instability and game crashes. Very low CPU clock values like 5% are likely to cause severe issues.
Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift [39-42]
-.init(title: "5%", description: "5%", value: 5),
-.init(title: "10%", description: "10%", value: 10),
-.init(title: "15%", description: "15%", value: 15),
-.init(title: "20%", description: "20%", value: 20),
+.init(title: "50%", description: "50%", value: 50),
+.init(title: "60%", description: "60%", value: 60),
+.init(title: "70%", description: "70%", value: 70),
+.init(title: "80%", description: "80%", value: 80),
- Apply this suggestion Suggestion importance[1-10]: 9
Why: Extremely low CPU clock values (5-20%) could lead to severe system instability and game crashes. The suggestion to set a higher minimum threshold is crucial for maintaining system stability and preventing potential user frustration.
[MOVED]