-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more cpu clock options in emuThree #2363
base: develop
Are you sure you want to change the base?
Conversation
Lowering the cpu clock can significantly improve performance and is possible in emuThree and Folium. I have also added the description for cpu clock speed from Citra because it explains how it can cause freezes.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
I removed the 5%, 15%, 25% etc. cpu clock options that I added and just kept it down to increments of 10. This makes the list of options smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but I'm not able to test this since emuThree usually doesnt' build for me. @JoeMatt maybe you can test to see the effect?
User description
What does this PR do
Adds more cpu clock options in emuThree. Right now it's only 100, 200, 300, or 400%.
Where should the reviewer start
How should this be manually tested
Setting the cpu clock to a lower speed and running a game (20% seems to work the best). It should have higher performance
Any background context you want to provide
Lowering the cpu clock can significantly improve performance and is possible in emuThree and Folium. I have also added the description for cpu clock speed from Citra because it explains how it can cause freezes.
What are the relevant tickets
Screenshots (important for UI changes)
Questions
PR Type
enhancement
Description
emuThree
to include more granular settings from 5% to 90% and additional overclocking options at 125% and 150%.Changes walkthrough 📝
PVEmuThreeCoreOptions.swift
Expand CPU clock options and update descriptions
Cores/emuThree/PVEmuThreeCore/Core/PVEmuThreeCoreOptions.swift
performance impacts.