Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Desmume2015 Core Options #2023

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Desmume2015 Core Options #2023

wants to merge 4 commits into from

Conversation

JoeMatt
Copy link
Member

@JoeMatt JoeMatt commented Nov 24, 2022

Core Options exposed for DS core.

@JoeMatt JoeMatt requested a review from jasarien as a code owner November 24, 2022 07:33
@ghost
Copy link

ghost commented Nov 24, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@JoeMatt JoeMatt force-pushed the feature/desmume2015CoreOptions branch 2 times, most recently from 677ba6b to 84b0864 Compare November 24, 2022 07:57
@JoeMatt
Desmume2015 CoreOptions
14ef3f5 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt JoeMatt force-pushed the feature/desmume2015CoreOptions branch from 84b0864 to 14ef3f5 Compare November 24, 2022 08:03
@JoeMatt
desmume comment hardcoded vid size
7d10e8d 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
desmume add comments for core options todo
d3cc03a 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt
add jit.cpp
535fbfa 
Signed-off-by: Joseph Mattello <[email protected]>
@JoeMatt JoeMatt changed the title Desmume2015 Core Options [WIP] Desmume2015 Core Options Nov 27, 2022
@JoeMatt JoeMatt marked this pull request as draft November 27, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasarien jasarien Awaiting requested review from jasarien jasarien is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoeMatt