Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SEIPDv2 packet parsing error messages #215

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix SEIPDv2 packet parsing error messages #215

merged 1 commit into from
Jul 15, 2024

Conversation

twiss
Copy link
Member

@twiss twiss commented Jul 12, 2024

No description provided.

@twiss twiss requested a review from lubux July 12, 2024 16:03
lubux
lubux approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@lubux lubux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetically fmt.Sprintf("invalid aead cipher: %d", int(...)) might be nicer but it is also fine like that.

👍

@twiss
Copy link
Member Author

twiss commented Jul 15, 2024

Cosmetically fmt.Sprintf("invalid aead cipher: %d", int(...)) might be nicer but it is also fine like that.

Yeah, I agree but there are a lot of other places that do it like this so I'll keep it consistent for now ^.^

@twiss twiss merged commit ef6d672 into main Jul 15, 2024
8 checks passed
@twiss twiss deleted the fix-seipdv2-errors branch July 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubux lubux lubux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twiss @lubux