Ensure crypto refresh cleartext messages are parseable #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crypto refresh introduces a new header in cleartext messages, which prevents a new cleartext message from being parsed by the library. This commit updates the parsing function to accept the new header and ensures that cleartext messages with mixed signature versions can be verified.
lubux
changed the title
|
This pull request becomes obsolete with mr:313, which removes the salted hash header from the crypto refresh and makes the hash header optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crypto refresh introduces a new
SaltedHashheader in signed cleartext messages, which prevents a new message from being parsed by the library. This pull request updates the parsing function to accept the new header and ensures that a cleartext message containing multiple signatures with different versions can be verified.For example, the following cleartext message with a v4 and a v6 signature
can now be successfully verified with a v4 key.