Improved handling of mods in .msp files #3213
Open
+500
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otation, and probably toward using a more general mod naming convention (currently a hardcoded list in the msp reader code, should probably use the same mechanism as rest of Skyline). Putting this up for Nick to look at.
… unknown peptide modifications. In the event that a modification can't be understood, a message is written to the immediate window (formerly we failed silently, replacing the mod with an unmatchable string, and moved on)
nickshulman
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of mods defined in .msp using ")(" instead of "/" notation, and adding ability to consult UniMod for modifications not found in the default hardcoded list.
Also, issue a non-blocking message when a mod can't be recognized (formerly we failed silently)
Reported by user afshari1