Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skyline/work/20230710 add refine with shape correlation #2663

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Skyline/work/20230710 add refine with shape correlation #2663

wants to merge 45 commits into from

Commits on Jul 10, 2023

  1. Added Shape Correlation parmeter to consitency tab of the refine dialog

    @NateMG4
    NateMG4 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7b2ae00 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Modified consitency tab of RefineDlg to take an IncludedCutoff and Qu… 

    …antizationCutoff parameters
    @NateMG4
    NateMG4 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    99cfdd0 View commit details
    Browse the repository at this point in the history

  2. Added refinment based on shape correlation

    @NateMG4
    NateMG4 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3b21203 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Reimported iPRG data to included Shape Correlation data.

    @NateMG4
    NateMG4 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0aede84 View commit details
    Browse the repository at this point in the history

  2. Added test for Shape Correlation refinment settings

    @NateMG4
    NateMG4 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    06f2143 View commit details
    Browse the repository at this point in the history

  3. Added commandline support for shape correlation refinment settings

    @NateMG4
    NateMG4 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    599bc4e View commit details
    Browse the repository at this point in the history

  4. Changed RefineTest to check if any transition has shapecorrelation va… 

    …lue below test cutoff
    @NateMG4
    NateMG4 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    38b79fc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @NateMG4
    NateMG4 authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    3a905dc View commit details
    Browse the repository at this point in the history

  6. added new resources to CommandArgUsage.resx

    @NateMG4
    NateMG4 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7bf7df6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'Skyline/work/20230710_addRefineWithShapeCorrelation' of h… 

    …ttps://github.com/ProteoWizard/pwiz into Skyline/work/20230710_addRefineWithShapeCorrelation
    @NateMG4
    NateMG4 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f207e29 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Renamed command arguments for simplicity

    @NateMG4
    NateMG4 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d5bdf81 View commit details
    Browse the repository at this point in the history

  2. Changed SCQuantatizationCutoff to SCQuantativeCutoff

    @NateMG4
    NateMG4 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    993a31d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. fixed error in CommandArgsUsage

    @NateMG4
    NateMG4 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    3fd2a80 View commit details
    Browse the repository at this point in the history

  2. fixed name error in CommandArgUsage

    @NateMG4
    NateMG4 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    88d564d View commit details
    Browse the repository at this point in the history

  3. Added SC RefinmentSettings to PropertyNames

    @NateMG4
    NateMG4 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2107bce View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @NateMG4
    NateMG4 authored Jul 19, 2023
    Configuration menu
    Copy the full SHA
    6fcffa2 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Added selectors to compare max, or min shape correlation values

    @NateMG4
    NateMG4 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b68ed0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'Skyline/work/20230710_addRefineWithShapeCorrelation' of h… 

    …ttps://github.com/ProteoWizard/pwiz into Skyline/work/20230710_addRefineWithShapeCorrelation
    @NateMG4
    NateMG4 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1afa3fa View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Added test for includ and quant comparison types

    @NateMG4
    NateMG4 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    97d945d View commit details
    Browse the repository at this point in the history

  2. added included and quant comparison type arguments to SkylineCmd

    @NateMG4
    NateMG4 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c9cc3fd View commit details
    Browse the repository at this point in the history

  3. Fixed error where enum value out of defined range are not defaulted t… 

    …o ComparisonType.min
    @NateMG4
    NateMG4 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5d4b438 View commit details
    Browse the repository at this point in the history

  4. fixed error in CommandArgUsage

    @NateMG4
    NateMG4 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2f6619d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Fixed error where sc comparison type is -1

    @NateMG4
    NateMG4 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f91fa71 View commit details
    Browse the repository at this point in the history

  2. No longer dynamically resize comparison type combo box.

    @NateMG4
    NateMG4 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2377373 View commit details
    Browse the repository at this point in the history

  3. Removed extra files from TestData\Refine

    @NateMG4
    NateMG4 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    32de12d View commit details
    Browse the repository at this point in the history

  4. Changed QUANTIZATION to QUANTITATIVE

    @NateMG4
    NateMG4 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    659a839 View commit details
    Browse the repository at this point in the history

  5. Now checks if SC values are above cutoff to ensure correct behavior f… 

    …or null SC values
    @NateMG4
    NateMG4 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    9eeed97 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Removed unnecessary if statement

    @NateMG4
    NateMG4 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b56b73f View commit details
    Browse the repository at this point in the history

  2. Renamed Shape Correlation properties to fit format

    @NateMG4
    NateMG4 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    97fa1ca View commit details
    Browse the repository at this point in the history

  3. Set comparison type to null if SC cutoff has no value

    @NateMG4
    NateMG4 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ce3a392 View commit details
    Browse the repository at this point in the history

  4. Fixed resharper warnings

    @NateMG4
    NateMG4 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    524b484 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @NateMG4
    NateMG4 authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ca284e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @NateMG4
    NateMG4 authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    04694ed View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @brendanx67
    brendanx67 authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3b2bdf9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Fixed resharper warnings

    @NateMG4
    NateMG4 committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    451fa08 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'Skyline/work/20230710_addRefineWithShapeCorrelation' of h… 

    …ttps://github.com/ProteoWizard/pwiz into Skyline/work/20230710_addRefineWithShapeCorrelation
    @NateMG4
    NateMG4 committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d848549 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @NateMG4
    NateMG4 authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8150f92 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Fix code inspection

    Nicholas Shulman committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c671489 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'remotes/origin/master' into Skyline/wor… 

    …k/20230710_addRefineWithShapeCorrelation
    Nicholas Shulman committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7bd4ca4 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Merge remote-tracking branch 'remotes/origin/master' into Skyline/wor… 

    …k/20230710_addRefineWithShapeCorrelation
    Nicholas Shulman committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d76d222 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into Skyline/work/20230710_addRefineWithShapeCo… 

    …rrelation
    @nickshulman
    nickshulman authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    71fd0de View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge remote-tracking branch 'remotes/origin/master' into Skyline/wor… 

    …k/20230710_addRefineWithShapeCorrelation
    Nicholas Shulman committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    58d9807 View commit details
    Browse the repository at this point in the history

  2. Fix CodeInspection error about strings that should be moved out of Re… 

    …sources.resx

Change "ARG_REFINE_SC_INCLUDED_COMPARISON_TYPE" to use "ComparisonType" enum.
    Nicholas Shulman committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7958f26 View commit details
    Browse the repository at this point in the history

  3. RefineShapeCorrelationTest

    Nicholas Shulman committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    af724c8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'remotes/origin/master' into Skyline/wor… 

    …k/20230710_addRefineWithShapeCorrelation
    Nicholas Shulman committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    56b7fcf View commit details
    Browse the repository at this point in the history