Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tableEditing function more extendable #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make tableEditing function more extendable #107

wants to merge 2 commits into from

Conversation

Xheldon
Copy link

@Xheldon Xheldon commented Apr 18, 2020

There is a case that a doc may have two different table type. Thus there should make the tableEditing function which can used by pass a different 'key' to do that:

Plugin({
    ...tableEditing().spec,
    key: new PluginKey('otherSelectionCell'),
})

@marduke182 marduke182 requested review from RatoX and eshvedai April 21, 2020 03:18
@Xheldon
Copy link
Author

Xheldon commented Apr 23, 2020

Any ideas about this PR? @RatoX @eshvedai

@Xheldon
Copy link
Author

Xheldon commented May 16, 2020

Any ideas about this PR? @RatoX @eshvedai

If this PR not good enough to merge, could you tell me why? Thx in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant