Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update legacy_org_id, fetch by legacy user/org ids #33

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

mrmauer
Copy link
Contributor

@mrmauer mrmauer commented Sep 6, 2024

Context
BE PR

After PR

  1. update org's legacy_org_id
legacyId := "<LEGACY_ID>"
orgId, _ := uuid.Parse("c19165e3-4c00-4ed2-a321-98d48d4ea890")

auth.UpdateOrgMetadata(
    orgId,
    UpdateOrg{
        LegacyOrgId: &legacyId,
    }
)
  1. fetch/search orgs on the legacy id (case-sensitive string)
auth.FetchOrgByQuery(models.OrgQueryParams{
    LegacyOrgId: &legacyId,
})
  1. fetch/search users on the legacy id (case-sensitive string)
auth.FetchUsersByQuery(models.UserQueryParams{
    LegacyUserId: &legacyId,
})

Copy link

@itailevi98 itailevi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just want to confirm that this allows for backwards compatibility? (I dont remember if go packages update in place or not)

@mrmauer
Copy link
Contributor Author

mrmauer commented Sep 27, 2024

the back-compat works here. chatted offline.

@mrmauer mrmauer merged commit 8073a6f into main Sep 27, 2024
9 checks passed
@mrmauer mrmauer deleted the qp/legacy-id branch September 27, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants