Lexical autoloads #846
Open
Lexical autoloads #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, Emacs 31 fails to apply `make autoloads` with the following error.
$ make autoloads
***** MAKING AUTOGENERATED AUTOLOADS ****
emacs -batch -q -no-site-file -eval '(setq autoload-package-name "proof" generated-autoload-file "/Users/ianwahbe/.emacs.d/.cache/elpaca/repos/PG/generic/proof-autoloads.el")' -f batch-update-autoloads generic/ lib/ coq/ qrhl/
Error: void-function (batch-update-autoloads)
batch-update-autoloads()
command-line-1(("-eval" "(setq autoload-package-name \"proof\" generated-autoload-file \"/Users/ianwahbe/.emacs.d/.cache/elpaca/repos/PG/generic/proof-autoloads.el\")" "-f" "batch-update-autoloads" "generic/" "lib/" "coq/" "qrhl/"))
command-line()
normal-top-level()
debug-early-backtrace...done
Symbol’s function definition is void: batch-update-autoloads
gmake: *** [Makefile.devel:249: autoloads] Error 255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 changes:
-*- lexical-binding: t; -*-togeneric/proof-autoloads.el. This is preserved bymake autoloads, so no other change is needed to address Emacs 31 warns on missing lexical bindings forgeneric/proof-autoloads.el#845.(require 'autoload)to the command formake autoloads, sinceautoloadis not required by default in Emacs 31 (and possibly earlier).Fixes #845