Added test for AvatarEditorPreviewModelBuilder

ProjektAdLer · Feb 12, 2025 · 747cc80 · 747cc80
1 parent dda9d2a
commit 747cc80
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/...tarEditor/AvatarEditorPreview/AvatarEditorPreviewModel/AvatarEditorPreviewModelBuilder.ts b/...tarEditor/AvatarEditorPreview/AvatarEditorPreviewModel/AvatarEditorPreviewModelBuilder.ts
@@ -8,6 +8,9 @@ import CoreDIContainer from "~DependencyInjection/CoreDIContainer";
 import IAvatarPort from "src/Components/Core/Application/Ports/Interfaces/IAvatarPort";
 import PORT_TYPES from "~DependencyInjection/Ports/PORT_TYPES";
 import { HistoryWrapper } from "~ReactComponents/ReactRelated/ReactEntryPoint/HistoryWrapper";
+import ILoggerPort from "src/Components/Core/Application/Ports/Interfaces/ILoggerPort";
+import CORE_TYPES from "~DependencyInjection/CoreTypes";
+import { LogLevelTypes } from "src/Components/Core/Domain/Types/LogLevelTypes";
 
 @injectable()
 export default class AvatarEditorPreviewModelBuilder extends AsyncPresentationBuilder<
@@ -28,9 +31,11 @@ export default class AvatarEditorPreviewModelBuilder extends AsyncPresentationBu
   buildView(): void {
     super.buildView();
 
+    const logger = CoreDIContainer.get<ILoggerPort>(CORE_TYPES.ILogger);
+
     this.view!.asyncSetup().then(
       () => this.resolveIsCompleted(),
-      (e) => console.log(e),
+      (error) => logger.log(LogLevelTypes.ERROR, error),
     );
   }
 

diff --git a/...itor/AvatarEditorPreview/AvatarEditorPreviewModel/AvatarEditorPreviewModelBuilder.test.ts b/...itor/AvatarEditorPreview/AvatarEditorPreviewModel/AvatarEditorPreviewModelBuilder.test.ts
@@ -6,6 +6,9 @@ import PORT_TYPES from "../../../../../Core/DependencyInjection/Ports/PORT_TYPES
 import AvatarEditorPreviewModelView from "../../../../../Core/Presentation/AvatarEditor/AvatarEditorPreview/AvatarEditorPreviewModel/AvatarEditorPreviewModelView";
 import IScenePresenter from "../../../../../Core/Presentation/Babylon/SceneManagement/IScenePresenter";
 import SCENE_TYPES from "../../../../../Core/DependencyInjection/Scenes/SCENE_TYPES";
+import ILoggerPort from "../../../../../Core/Application/Ports/Interfaces/ILoggerPort";
+import CORE_TYPES from "../../../../../Core/DependencyInjection/CoreTypes";
+import { LogLevelTypes } from "../../../../../Core/Domain/Types/LogLevelTypes";
 
 const avatarPortMock = mock<AvatarPort>();
 const scenePresenterMock = mockDeep<IScenePresenter>();
@@ -64,4 +67,21 @@ describe("AvatarEditorPreviewModelBuilder", () => {
 
     expect(asyncSetupMock).toHaveBeenCalledTimes(1);
   });
+
+  test("buildView logs error if asyncSetup fails", async () => {
+    const error = new Error("Test error");
+    const loggerMock = mock<ILoggerPort>();
+    CoreDIContainer.rebind(CORE_TYPES.ILogger).toConstantValue(loggerMock);
+
+    const asyncSetupMock = jest
+      .spyOn(AvatarEditorPreviewModelView.prototype, "asyncSetup")
+      .mockRejectedValue(error);
+
+    systemUnderTest.buildViewModel();
+    systemUnderTest.buildView();
+
+    await Promise.resolve();
+
+    expect(loggerMock.log).toHaveBeenCalledWith(LogLevelTypes.ERROR, error);
+  });
 });