Fixed wrong container error message being used for ContainerResult.SL… #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Larson
reviewed
Jul 1, 2024
| @@ -239,7 +239,7 @@ class TransferItemCallback : ICmdCallback { | |||
| } | |||
|
|
|||
| ContainerResult.SLOT_OCCUPIED -> { | |||
| SystemMessageIntent(player, "@container_error_message:container08").broadcast() | |||
| SystemMessageIntent(player, "@container_error_message:container04").broadcast() | |||
There was a problem hiding this comment.
Please also change the same line in GrantLootService.java
madsboddum
force-pushed
the
fix/items/slot-occupied-error
branch
from
41a6e8e
to
4021345
Compare
|
Done!
________________________________
Fra: Josh ***@***.***>
Sendt: 1. juli 2024 05:08
Til: ProjectSWGCore/Holocore ***@***.***>
Cc: Mads Boddum ***@***.***>; Assign ***@***.***>
Emne: Re: [ProjectSWGCore/Holocore] Fixed wrong container error message being used for ContainerResult.SL… (PR #1579)
@Josh-Larson commented on this pull request.
________________________________
In src/main/java/com/projectswg/holocore/resources/support/global/commands/callbacks/TransferItemCallback.kt<#1579 (comment)>:
@@ -239,7 +239,7 @@ class TransferItemCallback : ICmdCallback {
}
ContainerResult.SLOT_OCCUPIED -> {
- SystemMessageIntent(player, ***@***.***_error_message:container08").broadcast()
+ SystemMessageIntent(player, ***@***.***_error_message:container04").broadcast()
Please also change the same line in GrantLootService.java
—
Reply to this email directly, view it on GitHub<#1579 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABDM34M5LZ6YBFBRNCTIWKTZKDB3JAVCNFSM6AAAAABKEMV66GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJQGMYTSNRZGU>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…OT_OCCUPIED