BuffService refactor #1537
Merged
BuffService refactor #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures and bugs outside the code
…set, simplifying BuffService slightly
…check below will catch it anyway
…) to just one way (CRC), to help reduce code complexity There was also a bug with re-applying the same buff, where the timer would not reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably more that can be done, but I think it's in pretty good shape now.
There's also a bugfix in here
Re-applying a buff doesn't reset the timer.
Can be reproduced by applying Center of Being rapidly, as it has completed cool down before the buff expires.
The fix is re-scheduling the buff expiration in case the buff hasn't expired yet and to do so recursively until the buff should be expired.