Hand out the newbie quest to newly created characters

[madsboddum]

I had to get a bit creative with the two intent handlers.

At the time CreatedCharacterIntent is emitted, the owner of the CreatureObject is null, because the client hasn't requested zone-in yet.

And when the character is being zoned in, we don't have access the character creation context.

For that reason, the recentlyCreatedCharacters field contains some short-lived state, as the client triggers the zone-in flow right after character creation.

[madsboddum]

I tried, but it turned out that the quest is set up to remove itself from the journal upon completion, so the quest would be given again.

________________________________ From: Josh ***@***.***> Sent: Friday, June 7, 2024 3:55:23 AM To: ProjectSWGCore/Holocore ***@***.***> Cc: Mads Boddum ***@***.***>; Assign ***@***.***> Subject: Re: [ProjectSWGCore/Holocore] Hand out the newbie quest to newly created characters (PR #1535) @Josh-Larson commented on this pull request.

________________________________ In src/main/java/com/projectswg/holocore/services/gameplay/newbie/NewbieService.kt<#1535 (comment)>:

+

+ @IntentHandler + private fun handlePlayerEventIntent(intent: PlayerEventIntent) { + if (intent.event != PlayerEvent.PE_ZONE_IN_SERVER) { + return + } + + val creatureObject = intent.player.creatureObject + + if (creatureObject !in recentlyCreatedCharacters) { + StandardLog.onPlayerTrace(this, creatureObject, "character not created recently, skipping newbie quest grant") + return + } + + val player = intent.player + GrantQuestIntent.broadcast(player, "quest/c_newbie_start") Could ya check the character age instead? And whether the quest was already granted — Reply to this email directly, view it on GitHub<#1535 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABDM34KNGJWY5RA6FIW53ULZGEHIXAVCNFSM6AAAAABI2IZQ7SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBTGQ4TENBRGU>. You are receiving this because you were assigned.Message ID: ***@***.***>