Scouts can harvest resources from creatures #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from animals Relates to GitHub issue ProjectSWGCore#1266 and ProjectSWGCore#1224
…ion to the amount of resources retrieved
…out of 7 usages simply wanted the "raw" name, and accessed it using StringId#getKey
…ources are not defined in RawResourceType
…urrent terrain, e.g. bone_mammal_tatooine
…rvest types of bone_mammal and meat_reptilian bone_mammal straight up doesn't exist in RawResourceType and meat_reptilian is spelled differently (meat_reptillian, with an extra L)
Josh-Larson
reviewed
Jul 27, 2023
...ava/com/projectswg/holocore/services/gameplay/crafting/resource/CreatureHarvestingService.kt
Outdated
Show resolved
Hide resolved
…der of parameters in HarvestHideIntent can never be an issue in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1224
Fixes #1266