Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted canceling a live auction into a separate class, both to red… #1327

Merged

Conversation

madsboddum
Copy link
Member

…uce the size of BazaarService and increase the test coverage of the important parts of the code

There's more code in BazaarService that could benefit from a similar treatment, but I figured I would take it in small steps and start here.

…uce the size of BazaarService and increase the test coverage of the important parts of the code

There's more code in BazaarService that could benefit from a similar treatment, but I figured I would take it in small steps and start here.
@madsboddum madsboddum self-assigned this Jul 19, 2023
@madsboddum madsboddum added the IMPROVEMENT Enhancement of an existing feature label Jul 19, 2023
@Josh-Larson Josh-Larson merged commit c68d12a into ProjectSWGCore:master Jul 25, 2023
1 check passed
@madsboddum madsboddum deleted the cancel_live_auction_refactor branch August 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IMPROVEMENT Enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants