Skip to content

Conversation

@marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Oct 2, 2025

In the process of writing this Wiki documentation page, I realized that several action types were undispatched.
https://github.com/ProjectMirador/mirador/wiki/Architecture-overview-4:-Mirador-state-changes-for-plugin-authors

  • Remove un-dispatched setWorkspaceFullscreen action
  • Remove un-dispatched ADD_MANIFEST action type
  • Remove un-dispatched window actions
  • Remove un-dispatched CLEAR_ACCESS_TOKEN_QUEUE from action types

Happy to discuss, but cleaning up unused actions will make the code easier to understand.

@marlo-longley marlo-longley force-pushed the actions-review branch 2 times, most recently from c7fa1cd to 3fb337b Compare October 2, 2025 20:33
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.1%. Comparing base (6a4aa4e) to head (12fc0d0).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4186     +/-   ##
=======================================
- Coverage   95.2%   95.1%   -0.1%     
=======================================
  Files        326     326             
  Lines      16192   16165     -27     
  Branches    2554    2545      -9     
=======================================
- Hits       15413   15364     -49     
- Misses       774     796     +22     
  Partials       5       5             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marlo-longley marlo-longley marked this pull request as ready for review October 2, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants