update Readme section based on my building locally experience #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demisx
force-pushed
the
chore/update-readme
branch
from
a489acd to
b9a2fbd
Compare
demisx
commented
Nov 19, 2024
| - [x] `@ScaleReader`; | ||
| - [x] `@Scale`; | ||
| - [x] `@ScaleGeneric`; | ||
| - [x] `@Ignore`; |
There was a problem hiding this comment.
These type of style changes were made by my VS Code prettier plug-in. Makes markdown code more consistent and easier to maintain. No big deal if I should rollback these. Just lmk.
demisx
commented
Nov 19, 2024
| find . -type d -name "build" | ||
| --- | ||
| (should be empty output) | ||
| ``` |
There was a problem hiding this comment.
This is the section ("Building Locally") where I mainly made the updates to make instructions up-to-date and easier to follow. Feel free to comment on the format.
pfrank13
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes updates to the root readme based on my experience building this client locally. There are also some style changes coming from auto-formatting plugin in VS Code. Not sure if this gonna be an issue.