Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some maneuver types rely on default modifier #240

Open
1ec5 opened this issue Apr 23, 2018 · 1 comment
Open

Some maneuver types rely on default modifier #240

1ec5 opened this issue Apr 23, 2018 · 1 comment
Labels

Comments

@1ec5
Copy link
Member

1ec5 commented Apr 23, 2018

The continue, end of road, fork, merge, and new name maneuver types have no subkey left or right, so (for example) a fork to the left ends up relying on the default subkey. This presents a problem for languages such as Finnish, in which the word for “left” or “right” varies according to context.

Fixing this issue will add a number of strings for each language to translate. Ideally, we’d use a more flexible translation file format, but for now we can add the strings anyways. Languages that don’t need these extra strings can use translation memory to minimize work.

/cc @akikoskinen @yuryleb @danpaz

@yuryleb
Copy link
Contributor

yuryleb commented Apr 24, 2018

The little step in good direction IMHO. Actually I'd like even to stop using modifier keyword at all to have completed phrases for each maneuver type with names/destinations substitution only. Perhaps this increases total number of phrases but makes all them much more easily translatable than now - all they will have 'finished' context with no dependencies to other phrases/words (I mean modifier values) those could require other words order or different words at all.

For example, now Russian phrases should use 'generic' Двигайтесь verb (Go) with modifier keyword but actually it's better to use other verbs depending on modifier value (Поверните for turns and Развернитесь for u-turn) and even split two-words modifiers like sharp left or slight left and place the verb between them (currently Russian modifier strings have no two words values as should be to avoid this problem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants