You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Danish, when the voice instructs you to turn left (or right), it says "Drej til venstresving" - literally, "Turn left turn" where it should be "Drej til venstre" (Turn left). Same goes with "Drej til højresving" -> "Drej til højre".
The affected maneuver types are roundabout_turn, fork, new_name, merge, notification, off ramp (“Take exit 123 on the left turn”), end_of_road, turn, and continue.
Part of the problem is that the generic words for “left”, “sharp left”, etc. have been translated as “left turn”, “sharp left turn”, etc.
Some localizations have done this intentionally because there’s no way to isolate the word “left” but insert it into a sentence after the fact. I’m not sure if this is the case for Danish; we might be able to just simplify the modifier translations. Ideally, common maneuvers would never have to insert the modifier entries. However, we’re currently relying on those entries in a few too many cases: #240.
Per mapbox/mapbox-navigation-android#1101, some instructions in the Danish localization include redundant directional modifiers:
This is evident from our test fixtures:
osrm-text-instructions/test/fixtures/v5/merge/left_default.json
Line 11 in 7a0cef3
The affected maneuver types are
roundabout_turn
,fork
,new_name
,merge
,notification
,off ramp
(“Take exit 123 on the left turn”),end_of_road
,turn
, andcontinue
.Part of the problem is that the generic words for “left”, “sharp left”, etc. have been translated as “left turn”, “sharp left turn”, etc.
osrm-text-instructions/languages/translations/da.json
Lines 30 to 35 in e21d464
Some localizations have done this intentionally because there’s no way to isolate the word “left” but insert it into a sentence after the fact. I’m not sure if this is the case for Danish; we might be able to just simplify the
modifier
translations. Ideally, common maneuvers would never have to insert themodifier
entries. However, we’re currently relying on those entries in a few too many cases: #240./cc @danesfeder @cmahopper
The text was updated successfully, but these errors were encountered: