Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant maneuver modifiers in Danish #258

Closed
1ec5 opened this issue Jul 25, 2018 · 0 comments · Fixed by #286
Closed

Redundant maneuver modifiers in Danish #258

1ec5 opened this issue Jul 25, 2018 · 0 comments · Fixed by #286

Comments

@1ec5
Copy link
Member

1ec5 commented Jul 25, 2018

Per mapbox/mapbox-navigation-android#1101, some instructions in the Danish localization include redundant directional modifiers:

In Danish, when the voice instructs you to turn left (or right), it says "Drej til venstresving" - literally, "Turn left turn" where it should be "Drej til venstre" (Turn left). Same goes with "Drej til højresving" -> "Drej til højre".

This is evident from our test fixtures:

The affected maneuver types are roundabout_turn, fork, new_name, merge, notification, off ramp (“Take exit 123 on the left turn”), end_of_road, turn, and continue.

Part of the problem is that the generic words for “left”, “sharp left”, etc. have been translated as “left turn”, “sharp left turn”, etc.

"left": "venstresving",
"right": "højresving",
"sharp left": "skarpt venstresving",
"sharp right": "skarpt højresving",
"slight left": "svagt venstresving",
"slight right": "svagt højresving",

Some localizations have done this intentionally because there’s no way to isolate the word “left” but insert it into a sentence after the fact. I’m not sure if this is the case for Danish; we might be able to just simplify the modifier translations. Ideally, common maneuvers would never have to insert the modifier entries. However, we’re currently relying on those entries in a few too many cases: #240.

/cc @danesfeder @cmahopper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant