-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add regression tests for zero-speed segment updates #7341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bc89327 to
f0eddec
Compare
f0eddec to
748ec17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Fixes incorrect routing/turn behavior when closing segments via --segment-speed-file during MLD customization, attributed to concurrent turn-penalty updates.
Changes:
- Add mutex-based synchronization around a turn-penalty write during parallel edge updates in the updater.
- Add Cucumber scenarios covering “closure shouldn’t cascade” routing regressions.
- Add an Unreleased changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/updater/updater.cpp | Introduces mutex/lock guard around a turn_weight_penalties update during tbb::parallel_for. |
| features/testbot/zero-speed-updates.feature | Adds regression scenarios to ensure closures don’t block turns at unrelated intersections or cascade to parallel routes. |
| CHANGELOG.md | Adds an Unreleased entry describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, I misunderstood how I have updated the PR title and description and feel free to close if not useful. |
Issue
Add Cucumber scenarios to verify that closing segments via
--segment-speed-filedoesn't incorrectly block turns at unrelated intersections or cascade to parallel routes.Also add a unit test documenting the turn_id uniqueness invariant and improves the turn penalty warning log.
Tasklist
Requirements / Relations
Related to #7332