Upgrade clang-format from version 15 to 19#7250
Upgrade clang-format from version 15 to 19#7250nyllet wants to merge 3 commits intoProject-OSRM:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 32 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| V=$(clang-format --version) | ||
| if [[ $V != *15.0* ]] ; then | ||
| echo "clang-format is not 15.0 (returned ${V})" | ||
| if [[ $V != *19.1* ]] ; then |
There was a problem hiding this comment.
The version check is overly specific, checking for exactly version 19.1. This will reject clang-format versions like 19.0.x or any future 19.2.x, 19.3.x releases. Consider using a more flexible pattern like 19 or 19. to allow any clang-format 19.x version.
|
|
||
| format-taginfo-docs: | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-24.10 |
There was a problem hiding this comment.
Ubuntu 24.10 is an interim release with support until July 2025. Using an interim release for CI can lead to maintenance issues when it reaches end-of-life. Consider using ubuntu-24.04 LTS instead, which has longer support (until 2029) and should also have clang-format-19 available through packages or can be easily installed.
2 participants
Issue
#7249
Tasklist
Requirements / Relations
none