Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Experiment for Fine Tuning ICON #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
ENH: Experiment for Fine Tuning ICON #65
Changes from all commits
a0c16350a98f20f942eb2837e218File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mask path appended without existence check, unlike labelmap handling.
Line 186 correctly appends
Nonewhen the labelmap doesn't exist, but line 188 unconditionally appends the maskPatheven if the file is missing. Whenmask_dilation_mm=0(line 236), the workflow won't derive masks and will fail if it tries to read a non-existent mask file.labelmap_paths.append(labelmap if labelmap.exists() else None) mask = seg_dir / f.replace(".nii.gz", "_mask.nii.gz") - mask_paths.append(mask) + mask_paths.append(mask if mask.exists() else None)📝 Committable suggestion
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.