Feat: 회원가입 페이지 UI 추가 구현 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NacreousCloud
requested changes
Oct 30, 2023
Choi-Jinwook
requested changes
Nov 3, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.github/workflows/check_errors.yml
Outdated
| run: yarn tsc-project |
There was a problem hiding this comment.
이 코드 패치에 대한 간단한 코드 리뷰를 도와드리겠습니다.
-
runs-on: self-hosted를 주석 처리하고runs-on: ubuntu-latest로 변경했습니다. 이렇게 함으로써 self-hosted 에이전트가 아닌 ubuntu-latest 에이전트에서 작업을 실행하게 됩니다. -
'Checkout' 단계 밑에 'Install dependencies' 단계가 누락되었는지 확인해야 합니다. 이 단계에서 프로젝트에 필요한 종속성(packages)을 설치하는 것이 일반적입니다. 만약 설치되어 있지 않다면 해당 단계를 추가해야 합니다.
-
마지막 줄에
\ No newline at end of file주석은 파일 끝에 새 줄이 없음을 나타냅니다. 파일의 가독성을 위해 새 줄을 추가해주는 것이 좋습니다.
개선 제안 및 버그 위험 사항은 다음과 같습니다:
- 'Install dependencies' 단계 추가 여부 확인
- 필요한 경우, tsc-project의 명령 실행 전에 환경 설정 작업을 체크하고 수행할 수 있는지 확인
리뷰가 유용한지 확인하시고 개발 작업에 도움이 되시기를 바랍니다!
…-web into feat/signup-page ; Conflicts: ; src/shared/styles/globals.css
…/catcher-web into feat/signup-page
|
다시 확인 부탁드립니다! |
NacreousCloud
approved these changes
Nov 8, 2023
| onChange, | ||
| ...props | ||
| }: InputProps) => { | ||
| const [preview, setPreview] = useState(type === "password" ? false : true); |
There was a problem hiding this comment.
Suggested change
| const [preview, setPreview] = useState(type === "password" ? false : true); | |
| const [preview, setPreview] = useState(type !== "password"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
테스트
TODO
생각할 것