전시회 크롤링입니다 #14
Open
전시회 크롤링입니다 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheolwon1994
reviewed
Nov 1, 2023
| public List<ObjectNode> exhibitionCrawling() { | ||
|
|
||
| //TODO 드라이버 경로 상황에 맞게 설정, 그에 따른 크롬 및 gradle 의존성 버전도 알맞게 수정 | ||
| System.setProperty("webdriver.chrome.driver", "C:/Users/dong/Downloads/chromedriver-win64/chromedriver-win64/chromedriver.exe"); |
There was a problem hiding this comment.
이 부분은 동원님 로컬에서만 동작을하겠군요. 흠 도커로 올릴때 크롬 드라이버도 추가해서 빌드하도록 설정이 필요해보이네요
There was a problem hiding this comment.
네넵 맞습니다! 그렇게 진행되어야 할거같아요
제 로컬에서 돌릴때도 하... 의존성 추가하는부분이랑 맞물려서 아무튼... 저기만 본인 크롬브라우저에 맞는 버전으로 바꾸면 돌려볼수있긴합니다
| driver.manage().timeouts().implicitlyWait(Duration.ofSeconds(20)); | ||
| } | ||
| //TODO driver.quit 에러 안나는 방법 서치 | ||
| // driver.quit(); |
There was a problem hiding this comment.
DB 통신할때 Connection 뚫고 나중에 끊는것처럼 try-with-resource 방법으로 하면 되지 않을까요?
Refactor: DB, KMS, SSH 값을 변경한다
…cher/batch-service into feat-dw-crawling-job
캠핑 아이템 feign 호출 & db 저장
…into feat-dw-crawling-job
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"전시회명, 기간, 분야, 장소" 정도 통합해서 써볼수있을거같고
전시회에 맞는 컬럼으로 "주최" 정도 따로 고려해볼 수 있을거같습니다.