Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Block Scope fix #109

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Using Block Scope fix #109

merged 4 commits into from
Oct 10, 2024

Conversation

ankit-privado
Copy link

  • Changed the position of AST creation for declaration statement because we need to scope entry before the block statement creation.

pandurangpatil
pandurangpatil approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@pandurangpatil pandurangpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment to fix.

...sharpsrc2cpg/src/main/scala/io/joern/csharpsrc2cpg/astcreation/AstForStatementsCreator.scala Show resolved Hide resolved
@pandurangpatil pandurangpatil merged commit 2811110 into master Oct 10, 2024
17 checks passed
@pandurangpatil pandurangpatil deleted the using-block-fix branch October 10, 2024 08:57
@pandurangpatil pandurangpatil restored the using-block-fix branch October 10, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandurangpatil pandurangpatil pandurangpatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankit-privado @pandurangpatil