[jssrc2cpg] - Graceful handling of error situation for jssrc2cpg (joe…

…rnio#3911) While processing `.ejs` files, if the astgen throws any error while parsing the file. We encoutner this error in Finish method where we read skiped file contents for the report. In case of `.ejs` files as we preprocess and convert that into `.js` file. And for some reason this `.js` file is not present at the expected place, we get file not found exception. I have handled the situation gracefully in order to avoid breaking the entire process of generating the CPG.
Privado-Inc · Dec 7, 2023 · 0db78f9 · 0db78f9
1 parent 185d465
commit 0db78f9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/joern-cli/frontends/jssrc2cpg/src/main/scala/io/joern/jssrc2cpg/passes/AstCreationPass.scala b/joern-cli/frontends/jssrc2cpg/src/main/scala/io/joern/jssrc2cpg/passes/AstCreationPass.scala
@@ -26,7 +26,12 @@ class AstCreationPass(cpg: Cpg, astGenRunnerResult: AstGenRunnerResult, config:
     astGenRunnerResult.skippedFiles.foreach { skippedFile =>
       val (rootPath, fileName) = skippedFile
       val filePath             = Paths.get(rootPath, fileName)
-      val fileLOC              = IOUtils.readLinesInFile(filePath).size
+      val fileLOC = Try(IOUtils.readLinesInFile(filePath)) match {
+        case Success(filecontent) => filecontent.size
+        case Failure(exception) =>
+          logger.warn(s"Failed to read file: '${filePath}'", exception)
+          0
+      }
       report.addReportInfo(fileName, fileLOC)
     }
   }

diff --git a/...cli/frontends/jssrc2cpg/src/test/scala/io/joern/jssrc2cpg/preprocessing/EjsPassTest.scala b/...cli/frontends/jssrc2cpg/src/test/scala/io/joern/jssrc2cpg/preprocessing/EjsPassTest.scala
@@ -70,6 +70,17 @@ class EjsPassTest extends AbstractPassTest {
           "user.name"
         )
     }
+
+    "invalid EJS file test" in AstFixture(
+      """
+        |<body>
+        |<h1>Welcome <%@#$= user.name %></h1>
+        |</body>
+        |""".stripMargin,
+      "index.js.ejs"
+    ) { cpg =>
+      cpg.file.l.size shouldBe 0
+    }
   }
 
 }