Skip to content

Conversation

@Onako2
Copy link

@Onako2 Onako2 commented Jul 13, 2023

PrismLauncher/PrismLauncher#1040 < PR that removed this feature

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for prismlauncher ready!

Name Link
🔨 Latest commit 5441e9f
🔍 Latest deploy log https://app.netlify.com/sites/prismlauncher/deploys/64b136aeb71b0400088f1fc4
😎 Deploy Preview https://deploy-preview-323--prismlauncher.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TheKodeToad
Copy link
Member

I recognise you, I don't know where from lol.

There's also
https://prismlauncher.org/wiki/help-pages/ftb-platform/

@Onako2
Copy link
Author

Onako2 commented Jul 13, 2023

I recognise you, I don't know where from lol.

There's also https://prismlauncher.org/wiki/help-pages/ftb-platform/

Ok, I'll add it..

@Onako2
Copy link
Author

Onako2 commented Jul 13, 2023

I recognise you, I don't know where from lol.

There's also https://prismlauncher.org/wiki/help-pages/ftb-platform/

Only the sceenshot is wrong. FTB Legacy still exists

@Trial97
Copy link
Member

Trial97 commented Jul 13, 2023

can I count on you when the PrismLauncher/PrismLauncher#235 is done?

@Onako2
Copy link
Author

Onako2 commented Jul 13, 2023

can I count on you when the PrismLauncher/PrismLauncher#235 is done?

Do you mean to readd? Yes

@TheKodeToad
Copy link
Member

I recognise you, I don't know where from lol.
There's also prismlauncher.org/wiki/help-pages/ftb-platform

Only the sceenshot is wrong. FTB Legacy still exists

Okay, that's fair enough

Onako2 added 2 commits July 13, 2023 14:38
Removed reference of FTB on the About page

Signed-off-by: Onako2 <[email protected]>
@Onako2
Copy link
Author

Onako2 commented Jul 13, 2023

uf. I accidentaly selected the wrong branch. How do I change the branch?

@TheKodeToad
Copy link
Member

For the PR? You can't. I don't think it's a big deal here though!

@Onako2
Copy link
Author

Onako2 commented Jul 14, 2023

For the PR? You can't. I don't think it's a big deal here though!

The problem is, that other references aren't in this PR. I could create another PR that contains all other changes

@TheKodeToad
Copy link
Member

Huh? Just push those changes to patch-1

removed mentions of FTB and updatted screenshot
@NLZ NLZ mentioned this pull request Sep 10, 2023
@NLZ
Copy link

NLZ commented Sep 10, 2023

Isn't it ready to be merged now? What's blocking it?

@Onako2
Copy link
Author

Onako2 commented Sep 10, 2023

I put it on the wrong branch, thanks for reminding me!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these screenshots were used on this help page: https://prismlauncher.org/wiki/help-pages/ftb-platform/

make sure to just remove these with the help page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@ZekeZDev
Copy link
Member

What do we want to do with this now 8.0 has ftb app import?

@ZekeZDev ZekeZDev self-assigned this Oct 31, 2023
@GameLord2011
Copy link

When will this be merged, as it's been more than 2 years since the start of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants