check that currentScript is set by a script tag with optional chaining #3869
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 329 files have changed, with a combined diff of -303.08 KB (-90.8%).
|
LeaVerou
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Hi @lkuechler, would you be able to repurpose this to be against v2? See comment on #3863
lkuechler
force-pushed
the
change-eslint-parser-options
branch
from
9ec8597 to
ccf25f8
Compare
✅ Deploy Preview for prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@LeaVerou I also applied the same changed to the v2 version now. There where a few more cases but I think I got all of them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR but using optional chaining: #3863