Fix phpstan issues

PrinsFrank · May 15, 2023 · f8ffda7 · f8ffda7
1 parent 0359e4c
commit f8ffda7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/Currency/CurrencyAlpha3.php b/src/Currency/CurrencyAlpha3.php
@@ -205,7 +205,7 @@ public function toCurrencyName(): CurrencyName
         return BackedEnum::fromKey(CurrencyName::class, $this->name);
     }
 
-    public function getSymbol(): CurrencySymbol
+    public function getSymbol(): ?CurrencySymbol
     {
         return CurrencySymbol::forCurrency($this);
     }

diff --git a/src/Currency/CurrencyName.php b/src/Currency/CurrencyName.php
@@ -205,7 +205,7 @@ public function toCurrencyNumeric(): CurrencyNumeric
         return BackedEnum::fromKey(CurrencyNumeric::class, $this->name);
     }
 
-    public function getSymbol(): CurrencySymbol
+    public function getSymbol(): ?CurrencySymbol
     {
         return CurrencySymbol::forCurrency($this);
     }

diff --git a/src/Currency/CurrencyNumeric.php b/src/Currency/CurrencyNumeric.php
@@ -215,7 +215,7 @@ public function toCurrencyName(): CurrencyName
         return BackedEnum::fromKey(CurrencyName::class, $this->name);
     }
 
-    public function getSymbol(): CurrencySymbol
+    public function getSymbol(): ?CurrencySymbol
     {
         return CurrencySymbol::forCurrency($this);
     }

diff --git a/src/Currency/CurrencySymbol.php b/src/Currency/CurrencySymbol.php
@@ -76,7 +76,11 @@ enum CurrencySymbol: string
 
     public static function forCurrency(CurrencyAlpha3|CurrencyName|CurrencyNumeric $currency): ?self
     {
-        return match($currency->toCurrencyAlpha3()) {
+        if ($currency instanceof CurrencyAlpha3 === false) {
+            $currency = $currency->toCurrencyAlpha3();
+        }
+
+        return match($currency) {
             CurrencyAlpha3::ADB_Unit_of_Account                                               => null,
             CurrencyAlpha3::Afghani                                                           => self::Afghani,
             CurrencyAlpha3::Algerian_Dinar                                                    => self::Algerian_Dinar,