Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve boolean handling in WithValidatedProps #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve boolean handling in WithValidatedProps #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/WithValidatedProperties.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ trait WithValidatedProperties
public function __construct()
{
$validationResult = ModelValidator::validateModel(new ReflectionClass(static::class));
if ($validationResult->passes() === false) {
if (! $validationResult->passes()) {
throw new InvalidModelException('Model is invalid: "' . implode('","', $validationResult->getErrors()) . '"');
}
}
Expand All @@ -36,12 +36,12 @@ public function __isset(string $name): bool
*/
public function __set(string $name, mixed $value): void
{
if (property_exists($this, $name) === false) {
if (! property_exists($this, $name)) {
throw new NonExistingPropertyException('Property with name "' . $name . '" does not exist');
}

$validationResult = PropertyValidator::validateProperty((new ReflectionClass(static::class))->getProperty($name), $value);
if ($validationResult->passes() === false) {
if (! $validationResult->passes()) {
throw new ValidationException('Value "' . $value . '" for property "' . $name . '" is invalid: "' . implode('","', $validationResult->getErrors()) . '"');
}

Expand Down