-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GETP-113 feat: 피플 좋아요 취소 기능 구현 #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
테스트 Fixture에 관한 것은 |
scv1702
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 리뷰 참고해주세요.
src/main/java/es/princip/getp/domain/people/exception/PeopleLikeErrorCode.java
Outdated
Show resolved
Hide resolved
src/main/java/es/princip/getp/domain/people/service/PeopleLikeService.java
Outdated
Show resolved
Hide resolved
src/test/java/es/princip/getp/domain/people/controller/ProjectLikeControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/es/princip/getp/domain/people/controller/ProjectLikeControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/es/princip/getp/domain/people/service/PeopleLikeServiceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/es/princip/getp/domain/people/controller/PeopleLikeController.java
Outdated
Show resolved
Hide resolved
src/main/java/es/princip/getp/domain/people/service/PeopleLikeService.java
Outdated
Show resolved
Hide resolved
src/test/java/es/princip/getp/domain/people/controller/ProjectLikeControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/es/princip/getp/domain/people/controller/ProjectLikeControllerTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현한 기능
📢 논의하고 싶은 내용
PeopleLikeService.get(Long Long)
메서드를 테스트를 하지 않는다면private
처리를 할 수 있는데 테스트를 위해서public
으로 변경하였습니다. 이런 경우 최종 배포전 테스트까지는public
으로 두다가private
으로 변경하는 게 어떨까요? 이 부분은 잘 몰라서 논의해 보고 싶네요!PeopleLikeService.get
메서드에 오버로딩을 적용해 보았습니다! 해당 부분에 대해서 의견 부탁드립니다!PeopleService
에getByMemberId
와getByPeopleId
는 매개변수가Long
타입 하나로 중복됩니다. 하지만 매개변수 타입이 중복되지 않는ServiceClass
의get
메서드는 앞으로 오버로딩 하는 방법으로 사용하면 어떨까요?🎸 기타
TestFixture
파일도Domain
기준으로 분리하는 게 어떨까요??