Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tool for person-person relationship types (#1500) #1724

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

blms
Copy link
Contributor

@blms blms commented Jan 22, 2025

In this PR

Per #1500:

  • Make Person-Document relationship type merge logic as generic as possible through mixins and inheritance
  • Reuse for both that and Person-Person relationship types

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (8edbbac) to head (b2a8829).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1724      +/-   ##
===========================================
+ Coverage    98.93%   98.95%   +0.01%     
===========================================
  Files          245      245              
  Lines        15930    16032     +102     
===========================================
+ Hits         15761    15864     +103     
+ Misses         169      168       -1     

@blms blms merged commit 9307235 into develop Jan 22, 2025
15 checks passed
@blms blms deleted the feature/1500-personperson-merge branch January 22, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant