-
Notifications
You must be signed in to change notification settings - Fork 475
Refactor eval configs: add EvalRunConfig and separate run-level vs env-level settings #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
willccbb
wants to merge
23
commits into
multi-env-evals
from
codex/rework-evalconfig-and-multievalconfig
Closed
Refactor eval configs: add EvalRunConfig and separate run-level vs env-level settings #737
willccbb
wants to merge
23
commits into
multi-env-evals
from
codex/rework-evalconfig-and-multievalconfig
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
c4d690d to
6c047c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
env_id,env_args,num_examples,rollouts_per_example) so TOML / env pyproject settings are decoupled from run-wide options.Description
EvalRunConfigpydantic model and reducedEvalConfigto env-only fields (env_id,env_args,num_examples,rollouts_per_example) inverifiers/types.py.run_evaluationnow accepts(env_config: EvalConfig, run_config: EvalRunConfig)andrun_multi_evaluationaccepts anEvalRunConfig, and result-path construction now takes both run and env config viaget_eval_results_path(run_config, env_config)inverifiers/utils/path_utils.pyandverifiers/utils/eval_utils.py.verifiers/scripts/eval.pyso per-env TOML settings buildEvalConfigobjects, while run-level settings (model, endpoints, sampling args, concurrency, saving, headers, etc.) are collected into a singleEvalRunConfigconstructed from CLI flags and endpoint registry lookup.docs/evaluation.mdanddocs/reference.mdto reflect the new TOML scope (per-env fields) and the newEvalRunConfigtype and precedence: TOML controls only per-env fields and CLI controls run-level options.Testing
pytestor CI run was requested).Codex Task
Note
Enables parallel evaluation of multiple environments and clarifies config boundaries between per-env and run-level settings.
EvalEnvConfig,EvalModelConfig,EvalSaveConfig, andEvalRunConfig;EvalConfignow nestsenv,model, andsaveverifiers/scripts/eval.py) to acceptenv_id_or_path(single, comma-separated, or TOML), build multipleEvalConfigs, and apply clear precedence (per-eval TOML → TOML defaults → CLI → env defaults → global)load_toml_config), detection (is_toml_config), and run executorrun_evaluationsto execute evals in parallelget_eval_results_path(run_config, eval_config)and prints per-eval results plus aggregate event loop lag performancedocs/evaluation.md,docs/reference.md) with multi-env usage, TOML schema, and precedence; adds sample configs underconfigs/evals/and local debug configtests/test_eval_cli.py); minor logging tweak inEventLoopLagMonitorWritten by Cursor Bugbot for commit 1ee8aa7. This will update automatically on new commits. Configure here.