Skip to content

fix(train-client): filter failed tool calls #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikasenghaas merged 4 commits into from
Aug 6, 2026
Merged

fix(train-client): filter failed tool calls #2266

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c4062d
fix(train-client): only OK-status tool calls reach the agent
mikasenghaas Aug 6, 2026
7ce4a9f
chore: drop the inline comment
mikasenghaas Aug 6, 2026
6e0987d
fix: withhold only UNKNOWN_TOOL, not every non-OK status
mikasenghaas Aug 6, 2026
4dc379a
chore: TODO for a first-class renderer signal
mikasenghaas Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions verifiers/v1/clients/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from openai import OpenAIError
from renderers import OverlongPromptError as RendererOverlongPromptError
from renderers import RenderedTokens, Renderer, RendererConfig
from renderers.base import ToolCallParseStatus

from verifiers.v1.clients.base import build_async_openai
from verifiers.v1.clients.client import SESSION_ID_HEADER, Client
Expand Down Expand Up @@ -115,6 +116,8 @@ def response_from_generate(
)
for i, tc in enumerate(result.get("tool_calls") or [])
if getattr(tc, "name", None)
# TODO: we need a better way for renderers to expose this
and getattr(tc, "status", None) != ToolCallParseStatus.UNKNOWN_TOOL
] or None
prompt_ids = result.get("prompt_ids") or []
completion_ids = result.get("completion_ids") or []
Expand Down
Loading