feat: normalize provider tool specifications - #119
Draft
hallerite wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolSpec(...)constructionWhy
Equivalent function tools use different wire schemas across providers. Renderers previously handled a mixture of flat and Chat-style definitions locally, so Responses, Anthropic, and MCP inputs could be rendered inconsistently or lose schema information during parsing. Normalizing once at the boundary keeps model-specific renderers provider-agnostic and makes unsupported execution protocols fail loudly instead of being silently misrepresented.
Stack
This is stacked on #118 (
codex/freeze-golden-corpus). The frozen golden corpus is unchanged by this PR.Validation
uv run ruff check .uv run ty check renderers(exit 0; existing advisory diagnostics only)uv buildNote
Normalize provider tool specifications across all renderers
normalize_tool_spec()/normalize_tool_specs(), canonical types (CanonicalToolSpec,FunctionSpec, etc.), and error types (ToolSpecError,UnsupportedToolSpecError).normalize_tool_specs()at the start of every renderer'srender()method and in the_build_param_type_index/_extract_tool_namesparsing helpers, replacing ad hoc envelope-unwrapping.ToolSpecErrororUnsupportedToolSpecErrorfor invalid or unsupported tool protocols, where they previously silently accepted arbitrary inputs.Macroscope summarized 2b19413.