Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat allow to fail early #18

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Feat allow to fail early #18

merged 2 commits into from
Aug 12, 2024

Conversation

samsja
Copy link
Member

@samsja samsja commented Aug 11, 2024

this pr allows for all of the diloco workers to fail if one of them disconnects. Useful for running experiment with fix amount of workers.

to merge after #17

@samsja samsja marked this pull request as ready for review August 11, 2024 14:26
@samsja samsja requested a review from Jackmin801 August 11, 2024 14:27
@samsja samsja force-pushed the feat-allow-to-fail-early branch from 023cf69 to 08ecdc4 Compare August 11, 2024 15:05
@samsja samsja merged commit eaae47a into main Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant