add 8bit quant all reduce support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
force-pushed
the
feat-allow-8bit-grad
branch
from
d15ac9e to
8e066fe
Compare
samsja
commented
Aug 1, 2024
Comment on lines
-112
to
-114
| raise ValueError( | ||
| f"Invalid hivemind_compression: {hivemind_compression}. Please choose 'none', 'fp16', or 'scaled-fp16'." | ||
| ) |
There was a problem hiding this comment.
the config is already catching mis naming and propose suggestion thanks to literal support in pydantic
samsja
force-pushed
the
feat-allow-8bit-grad
branch
from
8e066fe to
3f3c27d
Compare
Jackmin801
approved these changes
Aug 1, 2024
Comment on lines
-112
to
-114
| raise ValueError( | ||
| f"Invalid hivemind_compression: {hivemind_compression}. Please choose 'none', 'fp16', or 'scaled-fp16'." | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.