954 - Add tests coverage #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: order of code executions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hiaux0
commented
May 10, 2022
Comment on lines
+29
to
+32
| private static getDealService() { | ||
| // @ts-ignore - Hack to access dealService inside Cypress | ||
| return Cypress.dealService; | ||
| } |
There was a problem hiding this comment.
@dkent600
okay to have this changes in this PR, or do you prefer separate?
dkent600
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
jsdevtools/coverage-istanbul-loaderis more up to date, at least it works with webpack5)package-lock.json, because coverage reporter usesbabelheavilyMore specifically, aurelia-validation does not parse the helper code correctly aurelia/testing#94.
I found a fix, but would need to PR to the aurelia repo and stuff.
(Maybe we just fork ourselves, will create a ticket)
Testing
(note, the section below is from the updated README
Have to run a separate command to instrument the code (instrument = add helper code, that tracks when code was executed)
npm run start-dev:covThen can run other e2e commands
Before
After